Re: [PATCH v2] sched_ext: Replace rq_lock() to raw_spin_rq_lock() in scx_ops_bypass()

[Changwoo Min]

Hello again,

On 25. 1. 8. 17:42, Andrea Righi wrote:
> > This change fixes: 0e7ffff1b811 ("scx: Fix raciness in scx_ops_bypass()")
>
> We should use the `Fixes:` tag, put this right before your SoB line:
>
>   Fixes: 0e7ffff1b811 ("scx: Fix raciness in scx_ops_bypass()")
Ah! My bad!

> > Without this change, we observe the following warnings:
>
> Maybe report only the first warning, or even something small like this
> should be sufficient to identify the issue I think:
>
>   [    6.615205] rq->balance_callback && rq->balance_callback != &balance_push_callback
>   [    6.615208] WARNING: CPU: 2 PID: 0 at kernel/sched/sched.h:1730 __schedule+0x1130/0x1c90
Sure. Will fix it.

Regards,
Changwoo Min