Re: [PATCH v3 09/12] x86/amd_nb: Move SMN access code to a new amd_node driver

[Borislav Petkov]

On Wed, Jan 08, 2025 at 11:00:21AM +0530, Shyam Sundar S K wrote:
> > diff --git a/drivers/platform/x86/amd/pmf/core.c b/drivers/platform/x86/amd/pmf/core.c
> > index 06a97c533cb8..7f88f3121cf5 100644
> > --- a/drivers/platform/x86/amd/pmf/core.c
> > +++ b/drivers/platform/x86/amd/pmf/core.c
> > @@ -8,13 +8,13 @@
> >   * Author: Shyam Sundar S K <Shyam-sundar.S-k@xxxxxxx>
> >   */
> >  
> > -#include <asm/amd_nb.h>
> >  #include <linux/debugfs.h>
> >  #include <linux/iopoll.h>
> >  #include <linux/module.h>
> >  #include <linux/pci.h>
> >  #include <linux/platform_device.h>
> >  #include <linux/power_supply.h>
> > +#include <asm/amd_node.h>
> 
> You can adjust the first header inclusion to maintain alphabetical order.

It is the linux/ namespace first, then arch-specific asm/ namespace in case
the second gets to override some generic implementations from the first. You
can grep the tree for examples.

> >  #include "pmf.h"
> >  
> >  /* PMF-SMU communication registers */
> > diff --git a/drivers/ras/amd/atl/Kconfig b/drivers/ras/amd/atl/Kconfig
> > index 551680073e43..6e03942cd7da 100644
> > --- a/drivers/ras/amd/atl/Kconfig
> > +++ b/drivers/ras/amd/atl/Kconfig
> > @@ -10,6 +10,7 @@
> >  config AMD_ATL
> >  	tristate "AMD Address Translation Library"
> >  	depends on AMD_NB && X86_64 && RAS
> > +	depends on AMD_NODE
> 
> the above "depends on" can be updated to:

the ATL uses AMD_NB facilities (node_to_amd_nb()) so I'd prefer to have
explicit dependencies in Kconfig.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette