Re: [PATCH 2/3] dt-bindings: hwmon: adi,max31827: add MAX31875

[Krzysztof Kozlowski]

On 08/01/2025 09:25, John Erasmus Mari Geronimo wrote:
> Add max31875 to dt-bindings of max31827
> MAX31875 is low-power I2C temperature sensor similar to MAX31827
> 
> Signed-off-by: John Erasmus Mari Geronimo <johnerasmusmari.geronimo@xxxxxxxxxx>
> ---
>  .../bindings/hwmon/adi,max31827.yaml           | 18 ++++++++++++++++--
>  1 file changed, 16 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/hwmon/adi,max31827.yaml b/Documentation/devicetree/bindings/hwmon/adi,max31827.yaml
> index f60e06ab7..9363fa371 100644
> --- a/Documentation/devicetree/bindings/hwmon/adi,max31827.yaml
> +++ b/Documentation/devicetree/bindings/hwmon/adi,max31827.yaml
> @@ -4,16 +4,19 @@
>  $id: http://devicetree.org/schemas/hwmon/adi,max31827.yaml#
>  $schema: http://devicetree.org/meta-schemas/core.yaml#
>  
> -title: Analog Devices MAX31827, MAX31828, MAX31829 Low-Power Temperature Switch
> +title: Analog Devices MAX31827, MAX31828, MAX31829, MAX31875 Low-Power Temperature Switch
>  
>  maintainers:
> -  - Daniel Matyas <daniel.matyas@xxxxxxxxxx>
> +  - John Erasmus Mari Geronimo <johnerasmusmari.geronimo@xxxxxxxxxx>


This needs to be explained in commit msg.

>  
> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            const: adi,max31875
> +
> +    then:
> +      properties:
> +        adi,fault-q:
> +          enum: [1, 2, 4, 6]

You need to update top-level property to allow 6. Then narrow the
choices for rest of the variants.

>  
>  required:
>    - compatible


Best regards,
Krzysztof