Re: [PATCH net]

[Simon Horman]

On Wed, Jan 08, 2025 at 01:43:03PM +0530, Sudheer Kumar Doredla wrote:
> cpsw_ale_get_field was returning incorrect data when requesting higher
> word fields. Additionally, cpsw_ale_set_field was writing incorrect 
> data into the ALE entry while updating.
> 
> For example, while reading word2, word3 fields (62 to 64 bits), the word3
> data was shifted to an incorrect position after reading. The same issue
> occurred when setting an ALE entry.
> 
> This patch fixes the shifting of the word3 data by aligning it with the
> required fileds, ensuring the correct value is returned from
> cpsw_ale_get_field, even for higher words.
> It also ensures the correct vlaue is written into ALE entry using
> cpsw_ale_set_field.

Hi Sudheer,

It would be interesting to include some information on how this problem
manifests in practice.

And, as a fix for net this should have a fixes tag.
(Immediately above the other tags, no blank line in between.)

Perhaps this one is appropriate?

Fixes: b685f1a58956 ("net: ethernet: ti: cpsw_ale: Fix cpsw_ale_get_field()/cpsw_ale_set_field()")

> Signed-off-by: Sudheer Kumar Doredla <s-doredla@xxxxxx>

And, lastly, the subject for this patch seems to be missing.
Please add one:

	Subject: [PATCH v2 net] net: ethernet: ti: cpsw_ale: ...

The code changes themselves look good to me.
So with the above addressed, feel free to include.

Reviewed-by: Simon Horman <horms@xxxxxxxxxx>

...

-- 
pw-bot: changes-requested