RE: Re: [PATCH v4] PCI: rcar-ep: Fix the issue of the name parameter when calling devm_request_mem_region

[Biju Das]

> -----Original Message-----
> From: kingdix10@xxxxxx <kingdix10@xxxxxx>
> Sent: 08 January 2025 04:59
> Subject: Re: Re: [PATCH v4] PCI: rcar-ep: Fix the issue of the name parameter when calling
> devm_request_mem_region
> 
> On Tue, 2025-01-07 at 16:56 -0600, Bjorn Helgaas wrote:
> > On Tue, Jan 07, 2025 at 09:51:23PM +0800, kingdix10@xxxxxx wrote:
> > > From: King Dix <kingdix10@xxxxxx>
> > >
> > > When using devm_request_mem_region to request a resource, if the
> > > passed variable is a stack string variable, it will lead to an oops
> > > issue when executing the command cat /proc/iomem.
> > >
> > > Fix this by replacing outbound_name with the name of the previously
> > > requested resource.
> >
> > Thanks a lot for doing this work!
> >
> > Add "()" after function names in subject and commit log.
> >
> 
> Thanks for your review. I will fix the issue right now.
> 
> > Please include a couple lines of the oops message to help people
> > connect the problem with the fix.

Maybe Prabhakar should be able to provide Oops log, as it is tested on real platform??

> 
> > > Fixes: 2a6d0d63d999 ("PCI: rcar: Add endpoint mode support")
> > > Signed-off-by: King Dix <kingdix10@xxxxxx>
> > > Reviewed-by: Lad Prabhakar
> > > <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx>
> > > Tested-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx>

Cheers,
Biju