Re: [PATCH v3 3/3] nvme: handle connectivity loss in nvme_set_queue_count

[Sagi Grimberg]

On 07/01/2025 16:40, Daniel Wagner wrote:
> On Tue, Dec 24, 2024 at 12:35:23PM +0200, Sagi Grimberg wrote:
> > On 17/12/2024 10:35, Daniel Wagner wrote:
> > > On Fri, Nov 29, 2024 at 12:10:33PM +0100, Hannes Reinecke wrote:
> > > > > +	/*
> > > > > +	 * It's either a kernel error or the host observed a connection
> > > > > +	 * lost. In either case it's not possible communicate with the
> > > > > +	 * controller and thus enter the error code path.
> > > > > +	 */
> > > > > +	if (status < 0 || status == NVME_SC_HOST_PATH_ERROR)
> > > > >     		return status;
> > > > >     	/*
> > > > Hmm. Maybe checking for NVME_SC_DNR, too?
> > > if no one complains I'll update the check to:
> > >
> > > 	if (status < 0 || (status > 0 && (status & NVME_STATUS_DNR)) ||
> > > 	    status == NVME_SC_HOST_PATH_ERROR)
> > > 		return status;
> > >
> > > okay?
> > Why do we care about the DNR? are you going to retry based on it?
> I don't know if we should care. Hannes brought this up.

I don't see why should we care.