Re: [PATCH net] rtase: Fix a check for error in rtase_alloc_msix()

From: Kalesh Anakkur Purayil
Date: Wed Jan 08 2025 - 07:18:31 EST


On Wed, Jan 8, 2025 at 2:46 PM Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote:
>
> The pci_irq_vector() function never returns zero. It returns negative
> error codes or a positive non-zero IRQ number. Fix the error checking to
> test for negatives.
>
> Fixes: a36e9f5cfe9e ("rtase: Add support for a pci table in this module")
> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>

LGTM,
Reviewed-by: Kalesh AP <kalesh-anakkur.purayil@xxxxxxxxxxxx>


--
Regards,
Kalesh AP

Attachment: smime.p7s
Description: S/MIME Cryptographic Signature