Re: [PATCH] dt-bindings: display: Correct indentation and style in DTS example

[Geert Uytterhoeven]

Hi Krzysztof,

On Tue, Jan 7, 2025 at 1:58 PM Krzysztof Kozlowski
<krzysztof.kozlowski@xxxxxxxxxx> wrote:
> DTS example in the bindings should be indented with 2- or 4-spaces and
> aligned with opening '- |', so correct any differences like 3-spaces or
> mixtures 2- and 4-spaces in one binding.
>
> No functional changes here, but saves some comments during reviews of
> new patches built on existing code.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>

Thanks for your patch!

> --- a/Documentation/devicetree/bindings/display/renesas,cmm.yaml
> +++ b/Documentation/devicetree/bindings/display/renesas,cmm.yaml
> @@ -58,10 +58,10 @@ examples:
>      #include <dt-bindings/power/r8a7796-sysc.h>
>
>      cmm0: cmm@fea40000 {
> -         compatible = "renesas,r8a7796-cmm",
> -                      "renesas,rcar-gen3-cmm";
> -         reg = <0xfea40000 0x1000>;
> -         power-domains = <&sysc R8A7796_PD_ALWAYS_ON>;
> -         clocks = <&cpg CPG_MOD 711>;
> -         resets = <&cpg 711>;
> +        compatible = "renesas,r8a7796-cmm",
> +                     "renesas,rcar-gen3-cmm";

Nit: the compatible values fit on a single line.

> +        reg = <0xfea40000 0x1000>;
> +        power-domains = <&sysc R8A7796_PD_ALWAYS_ON>;
> +        clocks = <&cpg CPG_MOD 711>;
> +        resets = <&cpg 711>;
>      };

Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx> # renesas

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds