Re: [PATCH 3/3] dt-bindings:Add SQ52206 to ina2xx devicetree bindings

From: Guenter Roeck
Date: Wed Jan 08 2025 - 09:19:12 EST


On 1/7/25 23:06, Krzysztof Kozlowski wrote:
On 07/01/2025 14:01, Wenliang Yan wrote:
Documentation/devicetree/bindings/hwmon/ti,ina2xx.yaml | 1 +
1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/hwmon/ti,ina2xx.yaml b/Documentation/devicetree/bindings/hwmon/ti,ina2xx.yaml
index 05a9cb36cd82..f0b7758ab29f 100644
--- a/Documentation/devicetree/bindings/hwmon/ti,ina2xx.yaml
+++ b/Documentation/devicetree/bindings/hwmon/ti,ina2xx.yaml
@@ -20,6 +20,7 @@ description: |
properties:
compatible:
enum:
+ - silergy,sq52206

So it is compatible or not? You said same bindings, but not compatible?


What I mean is that SQ52206 is compatible.the datasheet depends on


Then compatibility should be expressed in fallback, but OTOH, your
linked changes suggest these are not compatible. Confusing commit msg.


It is 'backward compatible' with additional features. That means it is not
'compatible' in devicetree terminology.

Guenter