Re: [PATCH v5 4/5] tracing/kprobes: Simplify __trace_kprobe_create() by removing gotos

From: Steven Rostedt
Date: Wed Jan 08 2025 - 10:09:50 EST


On Wed, 8 Jan 2025 11:11:18 +0900
"Masami Hiramatsu (Google)" <mhiramat@xxxxxxxxxx> wrote:

> -static int __trace_kprobe_create(int argc, const char *argv[])
> +static int ___trace_kprobe_create(int argc, const char *argv[],
> + struct traceprobe_parse_context *ctx)
> {

I'm not sure I care about all the underscores. It just adds to confusion.

Maybe just:

static int __create_trace_kprobe(..)

?

-- Steve