Re: [PATCH v1 25/29] cxl/amd: Enable Zen5 address translation using ACPI PRMT

[Gregory Price]

On Wed, Jan 08, 2025 at 03:52:35PM +0100, Robert Richter wrote:
> On 07.01.25 18:28:57, Gregory Price wrote:
> > On Tue, Jan 07, 2025 at 03:10:11PM +0100, Robert Richter wrote:
> > > 
> > > Add a function cxl_port_setup_amd() to implement AMD platform specific
> > > code. Use Kbuild and Kconfig options respectivly to enable the code
> > > depending on architecture and platform options. Create a new file
> > > core/amd.c for this.
> > > 
> > 
> > A build option here specific to AMD doesn't seem the best. At Meta,
> > we try to maintain a platform agnostic kernel for our fleet (at least
> > for build options), and this would necessitate us maintaining separate
> > builds for AMD systems vs other vendors.
> > 
> > Is there a reason to simply not include it by default and just report
> > whether translation is required or not? (i.e. no build option)
> 
> There is no (menu) option for CXL_AMD, it is just checking the
> dependencies to AMD_NB (and indirectly arch, platform and vendor). In
> that case it is always enabled.
> 

Ah! I completely misunderstood the build option, my bad.  This makes
sense, sorry about that

~Gregory