Re: [PATCH] x86/entry: Add __init to ia32_emulation_override_cmdline()

[Vitaly Kuznetsov]

Vitaly Kuznetsov <vkuznets@xxxxxxxxxx> writes:

> ia32_emulation_override_cmdline() is an early_param() arg and these
> are only needed at boot time. In fact, all other early_param() functions
> in arch/x86 seem to have '__init' annotation and
> ia32_emulation_override_cmdline() is the only exception.
>
> Fixes: a11e097504ac ("x86: Make IA32_EMULATION boot time configurable")
> Signed-off-by: Vitaly Kuznetsov <vkuznets@xxxxxxxxxx>
> ---
>  arch/x86/entry/common.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/x86/entry/common.c b/arch/x86/entry/common.c
> index 94941c5a10ac..51efd2da4d7f 100644
> --- a/arch/x86/entry/common.c
> +++ b/arch/x86/entry/common.c
> @@ -142,7 +142,7 @@ static __always_inline int syscall_32_enter(struct pt_regs *regs)
>  #ifdef CONFIG_IA32_EMULATION
>  bool __ia32_enabled __ro_after_init = !IS_ENABLED(CONFIG_IA32_EMULATION_DEFAULT_DISABLED);
>  
> -static int ia32_emulation_override_cmdline(char *arg)
> +static int __init ia32_emulation_override_cmdline(char *arg)
>  {
>  	return kstrtobool(arg, &__ia32_enabled);
>  }

Post-holidays ping)

-- 
Vitaly