Re: [PATCH net-next v2 13/14] net: ethernet: qualcomm: Add PPE debugfs support for PPE counters
From: Andrew Lunn
Date: Wed Jan 08 2025 - 11:45:15 EST
On Wed, Jan 08, 2025 at 09:47:20PM +0800, Luo Jie wrote:
> The PPE hardware packet counters are made available through
> the debugfs entry "/sys/kernel/debug/ppe/packet_counters".
Why?
Would it not be better to make them available via ethtool -S ?
You should justify not using standard statistics APIs for what look
like statistic counters. Maybe these don't fit the existing API, and
if so, you should explain why.
Andrew