Re: [PATCH RESEND v1 3/5] powerpc/kdump: preserve user-specified memory limit

From: Mahesh J Salgaonkar
Date: Wed Jan 08 2025 - 12:07:24 EST


On 2025-01-08 15:44:56 Wed, Sourabh Jain wrote:
> Commit 59d58189f3d9 ("crash: fix crash memory reserve exceed system
> memory bug") fails crashkernel parsing if the crash size is found to be
> higher than system RAM, which makes the memory_limit adjustment code
> ineffective due to an early exit from reserve_crashkernel().
>
> Regardless lets not violated the user-specified memory limit by
> adjusting it. Remove this adjustment to ensure all reservations stay
> within the limit. Commit f94f5ac07983 ("powerpc/fadump: Don't update
> the user-specified memory limit") did the same for fadump.

Agreed.

Reviewed-by: Mahesh Salgaonkar <mahesh@xxxxxxxxxxxxx>

Thanks,
-Mahesh.