Re: [PATCH] perf: Fix a wrong help message

[Namhyung Kim]

Hello,

On Thu, Jan 09, 2025 at 12:36:57AM +0800, Jiachen Zhang wrote:
> The wrong help message may mislead users. This commit fixes it.
> 
> Fixes: 328ccdace885 ("perf report: Add --no-demangle option")
> Signed-off-by: Jiachen Zhang <me@xxxxxxxx>
> ---
>  tools/perf/builtin-report.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/perf/builtin-report.c b/tools/perf/builtin-report.c
> index 048c91960ba9..a286d156510a 100644
> --- a/tools/perf/builtin-report.c
> +++ b/tools/perf/builtin-report.c
> @@ -1422,7 +1422,7 @@ int cmd_report(int argc, const char **argv)
>  	OPT_STRING(0, "addr2line", &addr2line_path, "path",
>  		   "addr2line binary to use for line numbers"),
>  	OPT_BOOLEAN(0, "demangle", &symbol_conf.demangle,
> -		    "Disable symbol demangling"),
> +		    "Enable symbol demangling"),

Maybe this is better: "Enable symbol demangling.  Use --no-demangle to disable."

Thanks,
Namhyung


>  	OPT_BOOLEAN(0, "demangle-kernel", &symbol_conf.demangle_kernel,
>  		    "Enable kernel symbol demangling"),
>  	OPT_BOOLEAN(0, "mem-mode", &report.mem_mode, "mem access profile"),
> -- 
> 2.34.1
>