Re: [PATCH v7 14/17] mm: remove extra vma_numab_state_init() call

[Vlastimil Babka]

On 12/26/24 18:07, Suren Baghdasaryan wrote:
> vma_init() already memset's the whole vm_area_struct to 0, so there is
> no need to an additional vma_numab_state_init().
> 
> Signed-off-by: Suren Baghdasaryan <surenb@xxxxxxxxxx>

Reviewed-by: Vlastimil Babka <vbabka@xxxxxxx>

> ---
>  include/linux/mm.h | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/include/linux/mm.h b/include/linux/mm.h
> index 99f4720d7e51..40bbe815df11 100644
> --- a/include/linux/mm.h
> +++ b/include/linux/mm.h
> @@ -947,7 +947,6 @@ static inline void vma_init(struct vm_area_struct *vma, struct mm_struct *mm)
>  	vma->vm_mm = mm;
>  	vma->vm_ops = &vma_dummy_vm_ops;
>  	INIT_LIST_HEAD(&vma->anon_vma_chain);
> -	vma_numab_state_init(vma);
>  	vma_lockdep_init(vma);
>  	vma_init_lock(vma, false);
>  }