RE: [PATCH next] scsi: fnic: silence uninitialized variable warning

[Karan Tilak Kumar (kartilak)]

On Wednesday, January 8, 2025 1:16 AM, Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote:
>
> The debug code prints "oxid" but it isn't always initialized.
>
> Fixes: f828af44b8dd ("scsi: fnic: Add support for unsolicited requests and responses")
> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
> ---
> drivers/scsi/fnic/fdls_disc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/fnic/fdls_disc.c b/drivers/scsi/fnic/fdls_disc.c
> index 2534af2fff53..7928f94d3202 100644
> --- a/drivers/scsi/fnic/fdls_disc.c
> +++ b/drivers/scsi/fnic/fdls_disc.c
> @@ -3904,7 +3904,7 @@ fdls_process_abts_req(struct fnic_iport_s *iport, struct fc_frame_header *fchdr)
> uint8_t *frame;
> struct fc_std_abts_ba_acc *pba_acc;
> uint32_t nport_id;
> -     uint16_t oxid;
> +     uint16_t oxid = 0;
> struct fnic_tport_s *tport;
> struct fnic *fnic = iport->fnic;
> uint16_t frame_size = FNIC_ETH_FCOE_HDRS_OFFSET +
> --
> 2.45.2
>
>

The change look good. Thanks!
Reviewed-by: Karan Tilak Kumar <kartilak@xxxxxxxxx>

Regards,
Karan