Re: [PATCH net-next v2 07/14] net: ethernet: qualcomm: Initialize PPE queue settings

[Christophe JAILLET]

Le 08/01/2025 à 14:47, Luo Jie a écrit :
> Configure unicast and multicast hardware queues for the PPE
> ports to enable packet forwarding between the ports.
>
> Each PPE port is assigned with a range of queues. The queue ID
> selection for a packet is decided by the queue base and queue
> offset that is configured based on the internal priority and
> the RSS hash value of the packet.
>
> Signed-off-by: Luo Jie <quic_luoj@xxxxxxxxxxx>

...

> +		/* Initialize the queue offset of RSS hash as 0 to avoid the
> +		 * random hardware value that will lead to the unexpected
> +		 * destination queue generated.
> +		 */
> +		index = 0;

Useless.

> +		for (index = 0; index < PPE_QUEUE_HASH_NUM; index++) {
> +			ret = ppe_queue_ucast_offset_hash_set(ppe_dev, port_id,
> +							      index, 0);
> +			if (ret)
> +				return ret;
> +		}
> +	}
> +
> +	return 0;
> +}

...

CJ