Re: [PATCH v2 3/3] perf test: Update ftrace test to use --graph-opts

[Arnaldo Carvalho de Melo]

On Tue, Jan 07, 2025 at 02:43:52PM -0800, Namhyung Kim wrote:
> I found it failed on machines with limited memory because 16M byte
> per-cpu buffer is too big.  The reason it added the option is not to
> miss tracing data.  Thus we can limit the data size by reducing the
> function call depth instead of increasing the buffer size to handle the
> whole data.
> 
> As it used the same option in the test_ftrace_trace() and it was able
> to find the sleep function, it should work with the profile subcommand.
> 
> Get rid of other grep commands which might be affected by the depth
> change.
> 
> Cc: Thomas Richter <tmricht@xxxxxxxxxxxxx>

Hey, I think we should convert the above Cc: to:

Reported-by: Thomas Richter <tmricht@xxxxxxxxxxxxx>

As I think you became aware of this situation from a patch proposed by
Thomas?

I'm also CCing a few other folks that were CCed in Thomas patch, also
CCed here.

- Arnaldo

> Reviewed-by: James Clark <james.clark@xxxxxxxxxx>
> Signed-off-by: Namhyung Kim <namhyung@xxxxxxxxxx>
> ---
>  tools/perf/tests/shell/ftrace.sh | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/tools/perf/tests/shell/ftrace.sh b/tools/perf/tests/shell/ftrace.sh
> index 2df05052c324a21c..c243731d2fbf67aa 100755
> --- a/tools/perf/tests/shell/ftrace.sh
> +++ b/tools/perf/tests/shell/ftrace.sh
> @@ -67,11 +67,8 @@ test_ftrace_latency() {
>  
>  test_ftrace_profile() {
>      echo "perf ftrace profile test"
> -    perf ftrace profile -m 16M sleep 0.1 > "${output}"
> +    perf ftrace profile --graph-opts depth=5 sleep 0.1 > "${output}"
>      grep ^# "${output}"
> -    grep sleep "${output}"
> -    grep schedule "${output}"
> -    grep execve "${output}"
>      time_re="[[:space:]]+1[[:digit:]]{5}\.[[:digit:]]{3}"
>      # 100283.000 100283.000 100283.000          1   __x64_sys_clock_nanosleep
>      # Check for one *clock_nanosleep line with a Count of just 1 that takes a bit more than 0.1 seconds
> -- 
> 2.47.1.613.gc27f4b7a9f-goog