Re: [PATCH 09/10] netfilter: Add message pragma for deprecated xt_*.h, ipt_*.h.

From: Jozsef Kadlecsik
Date: Wed Jan 08 2025 - 15:51:35 EST


On Tue, 7 Jan 2025, Szőke Benjamin wrote:

> 2025. 01. 07. 20:39 keltezéssel, Jozsef Kadlecsik írta:
> > On Tue, 7 Jan 2025, egyszeregy@xxxxxxxxxxx wrote:
> >
> > > From: Benjamin Szőke <egyszeregy@xxxxxxxxxxx>
> > >
> > > Display information about deprecated xt_*.h, ipt_*.h files
> > > at compile time. Recommended to use header files with
> > > lowercase name format in the future.
> >
> > I still don't know whether adding the pragmas to notify about header
> > file deprecation is a good idea.
>
> Do you have any other ideas how can you display this information to the
> users/customers, that it is time to stop using the uppercase header
> files then they shall to use its merged lowercase named files instead in
> their userspace SW?

Honestly, I don't know. What about Jan's clever idea of having the
clashing filenames with identical content, i.e.

ipt_ttl.h:
#ifndef _IPT_TTL_H
#define _IPT_TTL_H
#include <linux/netfilter_ipv4/ipt_ttl_common.h>
#endif _IPT_TTL_H

ipt_TTL.h:
#ifndef _IPT_TTL_H
#define _IPT_TTL_H
#include <linux/netfilter_ipv4/ipt_ttl_common.h>
#endif _IPT_TTL_H

Would cloning such a repo on a case-insensitive filesystem produce errors
or would work just fine?

Best regards,
Jozsef
--
E-mail : kadlec@xxxxxxxxxxxxx, kadlec@xxxxxxxxxxxxxxxxx, kadlecsik.jozsef@xxxxxxxxx
Address: Wigner Research Centre for Physics
H-1525 Budapest 114, POB. 49, Hungary