Re: [PATCH] md: Replace deprecated kmap_atomic() with kmap_local_page()

From: Song Liu
Date: Wed Jan 08 2025 - 16:43:41 EST


On Wed, Jan 8, 2025 at 11:23 AM David Reaver <me@xxxxxxxxxxxxxxx> wrote:
>
> kmap_atomic() is deprecated and should be replaced with kmap_local_page()
> [1][2]. kmap_local_page() is faster in kernels with HIGHMEM enabled, can
> take page faults, and allows preemption.
>
> According to [2], this is safe as long as the code between kmap_atomic()
> and kunmap_atomic() does not implicitly depend on disabling page faults or
> preemption. It appears to me that none of the call sites in this patch
> depend on disabling page faults or preemption; they are all mapping a page
> to simply extract some information from it or print some debug info.
>
> [1] https://lwn.net/Articles/836144/
> [2] https://docs.kernel.org/mm/highmem.html#temporary-virtual-mappings
>
> Signed-off-by: David Reaver <me@xxxxxxxxxxxxxxx>

LGTM. Applied to md-6.14.

Thanks for the patch!

Song