Re: linux-next: build failure after merge of the pinctrl tree

[Linus Walleij]

On Wed, Jan 8, 2025 at 10:47 PM Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx> wrote:
> On Mon, 6 Jan 2025 16:46:30 +1100 Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx> wrote:
> >
> > After merging the pinctrl tree, today's linux-next build (x86_64
> > allmodconfig) failed like this:
> >
> > drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c: In function 'mtk_pinconf_bias_set_pd':
> > drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c:606:13: error: unused variable 'err' [-Werror=unused-variable]
> >   606 |         int err, pd;
> >       |             ^~~
> > drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c: At top level:
> > drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c:602:12: error: 'mtk_pinconf_bias_set_pd' defined but not used [-Werror=unused-function]
> >   602 | static int mtk_pinconf_bias_set_pd(struct mtk_pinctrl *hw,
> >       |            ^~~~~~~~~~~~~~~~~~~~~~~
> > cc1: all warnings being treated as errors
> >
> > Caused by commit
> >
> >   1673d720b7e2 ("pinctrl: mediatek: add support for MTK_PULL_PD_TYPE")
> >
> > I have used the pinctrl tree from next-20241220 for today.
>
> I am still seeing these errors.

Sorry for not attending to it earlier.

I fixed this up by just adding a patch deleting the unused
mtk_pinconf_bias_set_pd() function. That should do it.

Thanks Stephen!

Yours,
Linus Walleij