RE: [PATCH v2] wifi: rtw89: Correct immediate cfg_len calculation for scan_offload_be

[Liang Jie]

On Thu, 9 Jan 2025 01:55:23 +0000, Ping-Ke Shih <pkshih@xxxxxxxxxxx> wrote:
> Liang Jie <buaajxlj@xxxxxxx> wrote: 
> > diff --git a/drivers/net/wireless/realtek/rtw89/fw.c b/drivers/net/wireless/realtek/rtw89/fw.c
> > index 2191c037d72e..2be1bee724ca 100644
> > --- a/drivers/net/wireless/realtek/rtw89/fw.c
> > +++ b/drivers/net/wireless/realtek/rtw89/fw.c
> > @@ -5170,6 +5170,7 @@ int rtw89_fw_h2c_scan_offload_be(struct rtw89_dev *rtwdev,
> >         u8 opch_size = sizeof(*opch) * option->num_opch;
> >         u8 probe_id[NUM_NL80211_BANDS];
> >         u8 cfg_len = sizeof(*h2c);
> > +       u8 ver = U8_MAX;
> >         unsigned int cond;
> >         void *ptr;
> >         int ret;
> 
> In reverse X'mas tree. Otherwise, looks good to me. 

Thank you for pointing out the "In reverse X'mas tree" issue in the code structure.
I will address this and submit [PATCH v3] with the necessary corrections.

Best regards,
Liang Jie