Re: [PATCH v8 0/5] Coresight: Add Coresight TMC Control Unit driver

[Jie Gan]

On 12/26/2024 9:10 AM, Jie Gan wrote:
> The Coresight TMC Control Unit(CTCU) device hosts miscellaneous configuration
> registers to control various features related to TMC ETR device.

[...]

> Changes in V8:
> 1. Rebased on tag next-20241220.
> 2. Use raw_spinlock_t instead of spinlock_t.
> 3. Remove redundant codes in CTCU driver:
>     - Eliminate unnecessary parameter validations.
>     - Correct log level when an error occurs.
>     - Optimize codes.
> 4. Correct the subject prefix for DT patch.
> 5. Collected reviewed-by tag from Konrad Dybcib for DT patch.
> Link to V7 - https://lore.kernel.org/all/20241210031545.3468561-1-quic_jiegan@xxxxxxxxxxx/

Kindly reminder.

Can you please help to review the patch series?

Thanks,
Jie

> Jie Gan (5):
>    Coresight: Add support for new APB clock name
>    Coresight: Add trace_id function to retrieving the trace ID
>    dt-bindings: arm: Add Coresight TMC Control Unit hardware
>    Coresight: Add Coresight TMC Control Unit driver
>    arm64: dts: qcom: sa8775p: Add CTCU and ETR nodes
>
>   .../bindings/arm/qcom,coresight-ctcu.yaml     |  84 ++++++
>   arch/arm64/boot/dts/qcom/sa8775p.dtsi         | 153 ++++++++++
>   drivers/hwtracing/coresight/Kconfig           |   8 +
>   drivers/hwtracing/coresight/Makefile          |   1 +
>   drivers/hwtracing/coresight/coresight-core.c  |  59 +++-
>   drivers/hwtracing/coresight/coresight-ctcu.c  | 273 ++++++++++++++++++
>   drivers/hwtracing/coresight/coresight-ctcu.h  |  21 ++
>   drivers/hwtracing/coresight/coresight-etb10.c |   3 +-
>   .../hwtracing/coresight/coresight-etm-perf.c  |  37 ++-
>   .../coresight/coresight-etm3x-core.c          |  30 ++
>   .../coresight/coresight-etm4x-core.c          |  29 ++
>   drivers/hwtracing/coresight/coresight-priv.h  |  13 +-
>   drivers/hwtracing/coresight/coresight-stm.c   |  22 ++
>   drivers/hwtracing/coresight/coresight-sysfs.c |  24 +-
>   .../hwtracing/coresight/coresight-tmc-etf.c   |   3 +-
>   .../hwtracing/coresight/coresight-tmc-etr.c   |   6 +-
>   drivers/hwtracing/coresight/coresight-tpda.c  |  20 ++
>   drivers/hwtracing/coresight/coresight-trbe.c  |   4 +-
>   drivers/hwtracing/coresight/ultrasoc-smb.c    |   3 +-
>   include/linux/coresight.h                     |  16 +-
>   20 files changed, 781 insertions(+), 28 deletions(-)
>   create mode 100644 Documentation/devicetree/bindings/arm/qcom,coresight-ctcu.yaml
>   create mode 100644 drivers/hwtracing/coresight/coresight-ctcu.c
>   create mode 100644 drivers/hwtracing/coresight/coresight-ctcu.h