Re: [PATCH v5 3/5] dt-bindings: pinctrl: at91-pio4: add microchip,sama7d65-pinctrl

From: Claudiu Beznea
Date: Thu Jan 09 2025 - 04:10:08 EST


Hi, Ryan,

On 07.01.2025 18:07, Ryan.Wanner@xxxxxxxxxxxxx wrote:
> From: Dharma Balasubiramani <dharma.b@xxxxxxxxxxxxx>
>
> Add pinctrl bindings for microchip sama7d65 SoC.
>
> Signed-off-by: Dharma Balasubiramani <dharma.b@xxxxxxxxxxxxx>
> Signed-off-by: Ryan Wanner <Ryan.Wanner@xxxxxxxxxxxxx>
> Acked-by: Rob Herring (Arm) <robh@xxxxxxxxxx>
> ---
> .../devicetree/bindings/pinctrl/atmel,at91-pio4-pinctrl.txt | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/pinctrl/atmel,at91-pio4-pinctrl.txt b/Documentation/devicetree/bindings/pinctrl/atmel,at91-pio4-pinctrl.txt
> index 774c3c269c40..4b9f3373503d 100644
> --- a/Documentation/devicetree/bindings/pinctrl/atmel,at91-pio4-pinctrl.txt
> +++ b/Documentation/devicetree/bindings/pinctrl/atmel,at91-pio4-pinctrl.txt
> @@ -6,7 +6,8 @@ configure it.
> Required properties:
> - compatible:
> "atmel,sama5d2-pinctrl"
> - "microchip,sama7g5-pinctrl"
> + "microchip,sama7d65-pinctrl", "microchip,sama7g5-pinctrl"

Looks like you have one space in front of the line

> + "microchip,sama7g5-pinctrl"

Same here. And this change should not be needed.

> - reg: base address and length of the PIO controller.
> - interrupts: interrupt outputs from the controller, one for each bank.
> - interrupt-controller: mark the device node as an interrupt controller.