Re: [PATCH net-next v2 01/14] dt-bindings: net: Add PPE for Qualcomm IPQ9574 SoC

[Krzysztof Kozlowski]

On Wed, Jan 08, 2025 at 09:47:08PM +0800, Luo Jie wrote:
> +    required:
> +      - clocks
> +      - clock-names
> +      - resets
> +      - interrupts
> +      - interrupt-names
> +
> +  ethernet-ports:

This device really looks like DSA or other ethernet switch, so I would
really expect proper $ref in top-level.

> +    type: object
> +    additionalProperties: false
> +    properties:
> +      '#address-cells':
> +        const: 1
> +      '#size-cells':
> +        const: 0
> +
> +    patternProperties:
> +      "^port@[1-6]$":
> +        type: object
> +        $ref: ethernet-controller.yaml#

Everything here is duplicating DSA or ethernet-switch, so that's
surprising.

> +        unevaluatedProperties: false
> +        description:
> +          PPE port that includes the MAC used to connect the external
> +          switch or PHY via the PCS.

Best regards,
Krzysztof