Re: [PATCH v3 1/2] hwmon: (acpi_power_meter) Fix uninitialized variables
From: Guenter Roeck
Date: Thu Jan 09 2025 - 15:45:00 EST
On Thu, Jan 09, 2025 at 04:17:07PM +0800, Huisong Li wrote:
> The 'power1_alarm' attribute uses the 'power' and 'cap' in the
> acpi_power_meter_resource structure. Currently, these two fields are just
> updated when user query 'power' and 'cap' attribute. If user directly query
> the 'power1_alarm' attribute without queryng above two attributes, driver
> will use uninitialized variables to judge.
>
> So this patch adds the setting of alarm state and update 'cap' in the
> notification callback and update 'power' and 'cap' if needed to show the
> real alarm state.
>
> Signed-off-by: Huisong Li <lihuisong@xxxxxxxxxx>
Applied.
Thanks,
Guenter