Re: [PATCH v4 5/5] acpi/ghes, cxl/pci: Process CXL CPER Protocol Errors

[Ira Weiny]

Smita Koralahalli wrote:

[snip]

> diff --git a/drivers/cxl/core/pci.c b/drivers/cxl/core/pci.c
> index 740ac5d8809f..5bad24965e24 100644
> --- a/drivers/cxl/core/pci.c
> +++ b/drivers/cxl/core/pci.c
> @@ -650,6 +650,68 @@ void read_cdat_data(struct cxl_port *port)
>  }
>  EXPORT_SYMBOL_NS_GPL(read_cdat_data, CXL);

FWIW this export changed to...

EXPORT_SYMBOL_NS_GPL(read_cdat_data, "CXL");

Which I think made this patch not apply directly.  Applying by hand fixed
it up.

>  
> +void cxl_cper_trace_corr_prot_err(struct pci_dev *pdev,
> +				  struct cxl_ras_capability_regs ras_cap)
> +{
> +	u32 status = ras_cap.cor_status & ~ras_cap.cor_mask;
> +	struct cxl_dev_state *cxlds;
> +
> +	cxlds = pci_get_drvdata(pdev);
> +	if (!cxlds)
> +		return;
> +
> +	trace_cxl_aer_correctable_error(cxlds->cxlmd, status);
> +}
> +EXPORT_SYMBOL_NS_GPL(cxl_cper_trace_corr_prot_err, CXL);

And all of the exports need quotes around CXL now due to:

commit cdd30ebb1b9f36159d66f088b61aee264e649d7a                   
Author: Peter Zijlstra <peterz@xxxxxxxxxxxxx>                     
Date:   Mon Dec 2 15:59:47 2024 +0100                             
                                                                  
    module: Convert symbol namespace to string literal            

Over all it looks ok though,
Ira

[snip]