Re: [PATCH] staging: rtl8723bs: Remove ioctl interface

[Arnd Bergmann]

On Thu, Jan 9, 2025, at 14:20, Yeking@xxxxxxxxx wrote:
> From: 谢致邦 (XIE Zhibang) <Yeking@xxxxxxxxx>
>
> Wireless drivers should not use the ioctl interface, so remove this
> interface for the rtl8723bs driver. (found by code inspection)
>
> Fixes: 8bfb36766064 ("wireless: wext: remove ndo_do_ioctl fallback")
> Fixes: 554c0a3abf21 ("staging: Add rtl8723bs sdio wifi driver")
> Signed-off-by: 谢致邦 (XIE Zhibang) <Yeking@xxxxxxxxx>
> ---
>  drivers/staging/rtl8723bs/Makefile            |    1 -
>  .../staging/rtl8723bs/include/osdep_intf.h    |    2 -
>  .../staging/rtl8723bs/os_dep/ioctl_linux.c    | 1286 -----------------
>  drivers/staging/rtl8723bs/os_dep/os_intfs.c   |    1 -
>  4 files changed, 1290 deletions(-)
>  delete mode 100644 drivers/staging/rtl8723bs/os_dep/ioctl_linux.c


Thanks for picking this up again. I had done a complete removal
of ndo_do_ioctl a while ago but hadn't gotten around to finishing
the upstreaming. For my older patches, see
https://lore.kernel.org/all/20231009141908.1767241-7-arnd@xxxxxxxxxx/

Your version is very similar but seems to miss a couple of stale
data structure and function declarations. Can you make sure you
include all those?

       Arnd