Re: [PATCH v4 1/2] dt-bindings: arm: rockchip: Add Firefly ITX-3588J board

[Heiko Stübner]

Am Montag, 16. Dezember 2024, 22:41:51 CET schrieb Shimrra Shai:
> Document board compatible bindings.
> 
> Signed-off-by: Shimrra Shai <shimrrashai@xxxxxxxxx>
> ---
>  Documentation/devicetree/bindings/arm/rockchip.yaml | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml
> index 753199a12..fc7ee86e2 100644
> --- a/Documentation/devicetree/bindings/arm/rockchip.yaml
> +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml
> @@ -167,6 +167,13 @@ properties:
>            - const: engicam,px30-core
>            - const: rockchip,px30
>  
> +      - description: Firefly Core-3588J-based boards
> +        items:
> +          - enum:
> +              - firefly,itx-3588j
> +          - const: firefly,core-3588j
> +          - const: rockchip,rk3588
> +
>        - description: Firefly Core-PX30-JD4 on MB-JD4-PX30 baseboard
>          items:
>            - const: firefly,px30-jd4-core-mb
> 

In v3 [0] the board dt-binding got an

Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>

so Krzysztof already noted, please carry those forward into new versions.


[0] https://lore.kernel.org/linux-arm-kernel/x7y24y3bkbj5fzx5pdprjr5umg6egxsy2xscfbj3xgzgzubvdk@ppncjiqoekk7/