Re: [PATCH v4 0/2] arm64: dts: rockchip: Add Firefly ITX-3588J Board

From: Heiko Stuebner
Date: Thu Jan 09 2025 - 18:15:22 EST



On Mon, 16 Dec 2024 15:41:50 -0600, Shimrra Shai wrote:
> Draft 4 for the device trees for this board. I hope this one finally
> addresses all outstanding style and organization issues. Note that the
> technical functionality limitations from the preceding versions remain.
>
> Changes since draft 3:
> * Removed the rockchip-pca9555.h header and used the pin numbers directly
> in the .dts.
> * Removed the display-subsystem node in the .dts. No other board seems to
> have one like the one that was there and it was causing warnings.
> * Removed extraneous property "rk806_dvs1_pwrdn" on the PMIC subnode on
> SPI2.
> * Removed an extraneous property "rockchip,skip-scan-in-resume" on the
> PCIe node pcie2x1l0.
>
> [...]

Applied, thanks!

[1/2] dt-bindings: arm: rockchip: Add Firefly ITX-3588J board
commit: 8886252102bd774656d19423b7d85e1ddd78f9c0
[2/2] arm64: dts: rockchip: add DTs for Firefly ITX-3588J and its Core-3588J SoM
commit: ebe82df46fba0f0fe45d7e03ddf5ca0f6e758a06

I've sorted some properties and dropped the status="okay" from the
fixed regulators added in the board dts.
status=okay is the default, so there is no need to add this to new
nodes.


Best regards,
--
Heiko Stuebner <heiko@xxxxxxxxx>