Re: [PATCH v6 5/5] tracing: Adopt __free() and guard() for trace_fprobe.c

From: Google
Date: Thu Jan 09 2025 - 18:58:02 EST


On Thu, 9 Jan 2025 09:56:07 -0500
Steven Rostedt <rostedt@xxxxxxxxxxx> wrote:

> On Thu, 9 Jan 2025 23:30:22 +0900
> "Masami Hiramatsu (Google)" <mhiramat@xxxxxxxxxx> wrote:
>
> > From: Masami Hiramatsu (Google) <mhiramat@xxxxxxxxxx>
> >
> > Adopt __free() and guard() for trace_fprobe.c to remove gotos.
> >
> > Signed-off-by: Masami Hiramatsu (Google) <mhiramat@xxxxxxxxxx>
> > ---
> > Changes in v6:
> > - Rename trace_fprobe_create* functions.
> > - Rename __free label for trace_fprobe.
> > - Simplify the last part of trace_fprobe_create_internal().
> > ---
> > kernel/trace/trace_fprobe.c | 130 ++++++++++++++++++++-----------------------
> > 1 file changed, 61 insertions(+), 69 deletions(-)
>
> Reviewed-by: Steven Rostedt (Google) <rostedt@xxxxxxxxxxx>

Thanks for review (and commented!)

>
> -- Steve


--
Masami Hiramatsu (Google) <mhiramat@xxxxxxxxxx>