Re: [patch 2/2] sched/debug: Remove need_resched ratelimiting for warnings
From: David Rientjes
Date: Thu Jan 09 2025 - 19:23:04 EST
On Thu, 9 Jan 2025, Josh Don wrote:
> > Otherwise, please take a look, is this what you had in mind?
>
> I'm realizing now that we'll end up getting multiple splats for a
> single very long stall (one per the warning threshold). We could fix
> that by using a magic number rather than 0 here (such as U64_MAX), and
> then teach resched_latency() to bail out on this value.
>
Ack, ok. I'll drop this patch because I see that there are existing users
(at least one NVMe library) that cares about tuning both of these values
with what appears to be some amount of thought:
/sys/kernel/debug/sched/latency_warn_once=0
/sys/kernel/debug/sched/latency_warn_ms=16
and the intent was not that they get excessive output that they don't need
or aren't expecting. Thanks for looking at this!