Re: [PATCH] selftests/net/forwarding: teamd command not found

From: Hangbin Liu
Date: Thu Jan 09 2025 - 23:09:27 EST


On Fri, Jan 10, 2025 at 01:07:44AM +0100, Alessandro Zanni wrote:
> Running "make kselftest TARGETS=net/forwarding" results in several
> occurrences of the same error:
> ./lib.sh: line 787: teamd: command not found
>
> Since many tests depends on teamd, this fix stops the tests if the
> teamd command is not installed.
>
> Signed-off-by: Alessandro Zanni <alessandro.zanni87@xxxxxxxxx>
> ---
> tools/testing/selftests/net/forwarding/lib.sh | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tools/testing/selftests/net/forwarding/lib.sh b/tools/testing/selftests/net/forwarding/lib.sh
> index 7337f398f9cc..a6a74a4be4bf 100644
> --- a/tools/testing/selftests/net/forwarding/lib.sh
> +++ b/tools/testing/selftests/net/forwarding/lib.sh
> @@ -784,6 +784,7 @@ team_destroy()
> {
> local if_name=$1; shift
>
> + require_command $TEAMD
> $TEAMD -t $if_name -k
> }

I saw team_create() has `require_command $TEAMD`. Is some test called
team_destroy() before team_create()?