Re: [PATCH] x86/e820: update code comment about e820_table_kexec
From: Dave Young
Date: Fri Jan 10 2025 - 01:21:52 EST
On Mon, 30 Sept 2024 at 11:00, Baoquan He <bhe@xxxxxxxxxx> wrote:
>
> On 09/14/24 at 07:20pm, Dave Young wrote:
> > The setup_data ranges are not reserved for kexec any more after
> > commit fc7f27cda843 ("x86/kexec: Do not update E820 kexec table
> > for setup_data"), so update the code comment here.
> >
> > Signed-off-by: Dave Young <dyoung@xxxxxxxxxx>
> > ---
> > arch/x86/kernel/e820.c | 6 ++----
> > 1 file changed, 2 insertions(+), 4 deletions(-)
> >
> > Index: linux-x86/arch/x86/kernel/e820.c
> > ===================================================================
> > --- linux-x86.orig/arch/x86/kernel/e820.c 2024-09-14 10:39:57.423551301 +0800
> > +++ linux-x86/arch/x86/kernel/e820.c 2024-09-14 18:56:30.158316496 +0800
> > @@ -36,10 +36,8 @@
> > *
> > * - 'e820_table_kexec': a slightly modified (by the kernel) firmware version
> > * passed to us by the bootloader - the major difference between
> > - * e820_table_firmware[] and this one is that, the latter marks the setup_data
> > - * list created by the EFI boot stub as reserved, so that kexec can reuse the
> > - * setup_data information in the second kernel. Besides, e820_table_kexec[]
> > - * might also be modified by the kexec itself to fake a mptable.
> > + * e820_table_firmware[] and this one is that e820_table_kexec[]
> > + * might be modified by the kexec itself to fake a mptable.
> > * We use this to:
>
> LGTM,
>
> Acked-by: Baoquan He <bhe@xxxxxxxxxx>
Ping. I forgot this patch. Can x86 maintainers take this one?
Thanks
Dave