Re: [PATCH v4 2/7] dt-bindings: PCI: dw: rockchip: Add rk3576 support

[Kever Yang]

Hi Krzysztof,

On 2025/1/8 16:16, Krzysztof Kozlowski wrote:
> On Tue, Jan 07, 2025 at 03:49:06PM +0800, Kever Yang wrote:
> > rk3576 is using dwc controller, with msi interrupt directly to gic instead
> > of to gic its, so
> > - no its support is required and the 'msi-map' is not need anymore,
> > - a new 'msi' interrupt is needed.
> >
> > Signed-off-by: Kever Yang <kever.yang@xxxxxxxxxxxxxx>
> > ---
> >
> > Changes in v4:
> > - Fix wrong indentation in dt_binding_check report by Rob
> >
> > Changes in v3:
> > - Fix dtb check broken on rk3588
> > - Update commit message
> >
> > Changes in v2:
> > - remove required 'msi-map'
> > - add interrupt name 'msi'
> >
> >   .../devicetree/bindings/pci/rockchip-dw-pcie-common.yaml      | 4 +++-
> >   Documentation/devicetree/bindings/pci/rockchip-dw-pcie.yaml   | 4 +---
> >   2 files changed, 4 insertions(+), 4 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/pci/rockchip-dw-pcie-common.yaml b/Documentation/devicetree/bindings/pci/rockchip-dw-pcie-common.yaml
> > index cc9adfc7611c..e4fcc2dff413 100644
> > --- a/Documentation/devicetree/bindings/pci/rockchip-dw-pcie-common.yaml
> > +++ b/Documentation/devicetree/bindings/pci/rockchip-dw-pcie-common.yaml
> > @@ -81,7 +81,9 @@ properties:
> >         - const: msg
> >         - const: legacy
> >         - const: err
> > -      - const: dma0
> > +      - enum:
> > +          - msi
> > +          - dma0
> Commit msg said new interrupt, but this basically replaces existing DMA0
> interrupt. Maybe that's the problem with this common binding and you
> just miss constraining in each device binding. If so: fix also them.
rk3588 has 9 interrupt, and the 6th-9th is dma0-3;
rk3568 only has 5 interrupts, no dma0-3;
rk3576 add one more "msi" interrupt which is the 6th interrupt;
The upcomming rk3562 is the same as rk3576.
I'm sorry I'm not so good at this yaml grammar, how should I take care 
of this case?


Thanks,
- Kever
> Also: your interrupts property does not match this anymore.
>
> Best regards,
> Krzysztof