[PATCH] scsi: fnic: Return appropriate error code for mem alloc failure
From: Karan Tilak Kumar
Date: Fri Jan 10 2025 - 04:23:27 EST
Return appropriate error code from fnic_probe when memory create slab
pool fails. Fix bug report.
Suggested-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
Reviewed-by: Sesidhar Baddela <sebaddel@xxxxxxxxx>
Reviewed-by: Arulprabhu Ponnusamy <arulponn@xxxxxxxxx>
Reviewed-by: Gian Carlo Boffa <gcboffa@xxxxxxxxx>
Reviewed-by: Arun Easi <aeasi@xxxxxxxxx>
Signed-off-by: Karan Tilak Kumar <kartilak@xxxxxxxxx>
---
drivers/scsi/fnic/fnic_main.c | 16 ++++++++++++----
1 file changed, 12 insertions(+), 4 deletions(-)
diff --git a/drivers/scsi/fnic/fnic_main.c b/drivers/scsi/fnic/fnic_main.c
index b5dca8e7e2e4..d366cbca04d5 100644
--- a/drivers/scsi/fnic/fnic_main.c
+++ b/drivers/scsi/fnic/fnic_main.c
@@ -888,24 +888,32 @@ static int fnic_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
}
pool = mempool_create_slab_pool(2, fnic_sgl_cache[FNIC_SGL_CACHE_DFLT]);
- if (!pool)
+ if (!pool) {
+ err = -ENOMEM;
goto err_out_free_resources;
+ }
fnic->io_sgl_pool[FNIC_SGL_CACHE_DFLT] = pool;
pool = mempool_create_slab_pool(2, fnic_sgl_cache[FNIC_SGL_CACHE_MAX]);
- if (!pool)
+ if (!pool) {
+ err = -ENOMEM;
goto err_out_free_dflt_pool;
+ }
fnic->io_sgl_pool[FNIC_SGL_CACHE_MAX] = pool;
pool = mempool_create_slab_pool(FDLS_MIN_FRAMES, fdls_frame_cache);
- if (!pool)
+ if (!pool) {
+ err = -ENOMEM;
goto err_out_fdls_frame_pool;
+ }
fnic->frame_pool = pool;
pool = mempool_create_slab_pool(FDLS_MIN_FRAME_ELEM,
fdls_frame_elem_cache);
- if (!pool)
+ if (!pool) {
+ err = -ENOMEM;
goto err_out_fdls_frame_elem_pool;
+ }
fnic->frame_elem_pool = pool;
/* setup vlan config, hw inserts vlan header */
--
2.47.1