Re: [PATCH] miscdevice: rust: use build_error! macro instead of function

From: Alice Ryhl
Date: Fri Jan 10 2025 - 07:33:41 EST


On Fri, Jan 10, 2025 at 1:23 PM Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
>
> On Fri, Jan 10, 2025 at 11:38:10AM +0100, Miguel Ojeda wrote:
> > On Fri, Jan 10, 2025 at 11:15 AM Alice Ryhl <aliceryhl@xxxxxxxxxx> wrote:
> > >
> > > The function called build_error is an implementation detail of the macro
> > > of the same name. Thus, update miscdevice to use the macro rather than
> > > the function. See [1] for more information on this.
> > >
> > > This use the macro with the kernel:: prefix as it has not yet been added
> > > to the prelude.
> >
> > Typo: "These"
> >
> > Acked-by: Miguel Ojeda <ojeda@xxxxxxxxxx>
>
> And I'll add a Reported-by: line when I apply this in a few minutes,
> thanks!

Good call, thanks!