[PATCH v1 3/4] cpuidle: teo: Reorder candidate state index checks
From: Rafael J. Wysocki
Date: Fri Jan 10 2025 - 07:58:16 EST
From: Rafael J. Wysocki <rafael.j.wysocki@xxxxxxxxx>
Since constraint_idx may be 0, the candidate state index may change to 0
after assinging constraint_idx to it, so first check if it is greater
than constraint_idx (and update it if so) and then check it against 0.
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@xxxxxxxxx>
---
drivers/cpuidle/governors/teo.c | 15 ++++++++-------
1 file changed, 8 insertions(+), 7 deletions(-)
--- a/drivers/cpuidle/governors/teo.c
+++ b/drivers/cpuidle/governors/teo.c
@@ -428,6 +428,14 @@
break;
}
}
+
+ /*
+ * If there is a latency constraint, it may be necessary to select an
+ * idle state shallower than the current candidate one.
+ */
+ if (idx > constraint_idx)
+ idx = constraint_idx;
+
if (!idx && prev_intercept_idx &&
!(drv->states[0].flags & CPUIDLE_FLAG_POLLING)) {
/*
@@ -440,13 +448,6 @@
}
/*
- * If there is a latency constraint, it may be necessary to select an
- * idle state shallower than the current candidate one.
- */
- if (idx > constraint_idx)
- idx = constraint_idx;
-
- /*
* Skip the timers check if state 0 is the current candidate one,
* because an immediate non-timer wakeup is expected in that case.
*/