Re: [PATCH] mtd: hyperbus: Use of_property_present() for non-boolean properties

From: Tudor Ambarus
Date: Fri Jan 10 2025 - 08:13:58 EST




On 1/9/25 6:21 PM, Rob Herring (Arm) wrote:
> The use of of_property_read_bool() for non-boolean properties is
> deprecated in favor of of_property_present() when testing for property
> presence.
>
> Signed-off-by: Rob Herring (Arm) <robh@xxxxxxxxxx>

Reviewed-by: Tudor Ambarus <tudor.ambarus@xxxxxxxxxx>

> ---
> drivers/mtd/hyperbus/hbmc-am654.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mtd/hyperbus/hbmc-am654.c b/drivers/mtd/hyperbus/hbmc-am654.c
> index 217f4e69233f..60bdce4391cd 100644
> --- a/drivers/mtd/hyperbus/hbmc-am654.c
> +++ b/drivers/mtd/hyperbus/hbmc-am654.c
> @@ -176,7 +176,7 @@ static int am654_hbmc_probe(struct platform_device *pdev)
> if (ret)
> return ret;
>
> - if (of_property_read_bool(dev->of_node, "mux-controls")) {
> + if (of_property_present(dev->of_node, "mux-controls")) {
> struct mux_control *control = devm_mux_control_get(dev, NULL);
>
> if (IS_ERR(control))