Re: [PATCH 2/3] kbuild: rust: apply `CONFIG_WERROR` to all Rust targets

From: Andreas Hindborg
Date: Fri Jan 10 2025 - 08:34:39 EST


Masahiro Yamada <masahiroy@xxxxxxxxxx> writes:

> On Wed, May 22, 2024 at 7:52 PM Miguel Ojeda
> <miguel.ojeda.sandonis@xxxxxxxxx> wrote:
>>
>> On Wed, May 22, 2024 at 12:14 PM Masahiro Yamada <masahiroy@xxxxxxxxxx> wrote:
>> >
>> > What does "everything else" mean exactly?
>>
>> Everything but the host programs. Or as many targets as possible, if
>> you think there are other cases that we should avoid.
>
>
> You can do this if rebuilding makes sense
> when any CONFIG option is changed.

Not having the ability to make builds fail when clippy or rustdoc is
issuing warnings is a big problem. I would very much like to have the
option to make builds fail when these targets give warnings.

@Miguel: Should I look into exempting host programs, or do you already
have an idea of how to implement?


Regarding host programs, it would be nice to set werror for those. How
does C do this? Is W=e enough?


Best regards,
Andreas Hindborg