Re: [PATCH 10/12] dt-bindings: phy: allwinner: add v853 usb phy

[Krzysztof Kozlowski]

On 10/01/2025 13:39, Andras Szemzo wrote:
> +
> +properties:
> +  "#phy-cells":
> +    const: 1
> +
> +  compatible:
> +    const:
> +	- allwinner,sun8i-v853-usb-phy

Wrong indentation, never tested.

Compatible is always the first property.

> +
> +  reg:
> +    items:
> +      - description: PHY Control registers
> +      - description: PHY PMU0 registers
> +
> +  reg-names:
> +    items:
> +      - const: phy_ctrl
> +      - const: pmu0
> +
> +  clocks:
> +    maxItems: 1
> +    description: USB OHCI PHY bus clock

Redundant description really...

> +
> +  clock-names:
> +    const: usb0_phy

Drop clock-names, not really helpful.


> +
> +  resets:
> +    maxItems: 1
> +    description: USB OHCI reset
> +
> +  reset-names:
> +    const: usb0_reset

Drop names, also not really helping.

> +
> +  usb0_id_det-gpios:

There are no properties with underscores.

I don't get why you are using "usb0" prefix. Document all pins, so
"usb1" as well, assuming it exists.

It anyway looks questionable - aren't these properties of connector?


> +    maxItems: 1
> +    description: GPIO to the USB OTG ID pin
> +
> +  usb0_vbus_det-gpios:
> +    maxItems: 1
> +    description: GPIO to the USB OTG VBUS detect pin
> +
> +  usb0_vbus_power-supply:
> +    description: Power supply to detect the USB OTG VBUS
> +
> +  usb0_vbus-supply:
> +    description: Regulator controlling USB OTG VBUS

Regulator and power supply are here synonyms, so I don't understand
these two properties.

> +
> +required:
> +  - "#phy-cells"
> +  - compatible
> +  - clocks
> +  - clock-names
> +  - reg
> +  - reg-names
> +  - resets
> +  - reset-names
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    #include <dt-bindings/gpio/gpio.h>
> +    #include <dt-bindings/clock/sun8i-v853-ccu.h>
> +    #include <dt-bindings/reset/sun8i-v853-ccu.h>
> +
> +    usbphy: phy@4100400 {
> +        #phy-cells = <1>;
Please follow DTS coding style.

Best regards,
Krzysztof