Re: [PATCH v2] perf: Fix a wrong help message

From: Arnaldo Carvalho de Melo
Date: Fri Jan 10 2025 - 09:42:20 EST


On Thu, Jan 09, 2025 at 04:29:57PM -0800, Namhyung Kim wrote:
> On Thu, Jan 09, 2025 at 11:22:19PM +0800, Jiachen Zhang wrote:
> > The wrong help message may mislead users. This commit fixes it.
> >
> > Fixes: 328ccdace885 ("perf report: Add --no-demangle option")
> > Signed-off-by: Jiachen Zhang <me@xxxxxxxx>
>
> Reviewed-by: Namhyung Kim <namhyung@xxxxxxxxxx>

Thanks, applied to perf-tools-next,

- Arnaldo

> Thanks,
> Namhyung
>
> > ---
> > tools/perf/builtin-report.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/tools/perf/builtin-report.c b/tools/perf/builtin-report.c
> > index 048c91960ba9..a5672749f781 100644
> > --- a/tools/perf/builtin-report.c
> > +++ b/tools/perf/builtin-report.c
> > @@ -1422,7 +1422,7 @@ int cmd_report(int argc, const char **argv)
> > OPT_STRING(0, "addr2line", &addr2line_path, "path",
> > "addr2line binary to use for line numbers"),
> > OPT_BOOLEAN(0, "demangle", &symbol_conf.demangle,
> > - "Disable symbol demangling"),
> > + "Symbol demangling. Enabled by default, use --no-demangle to disable."),
> > OPT_BOOLEAN(0, "demangle-kernel", &symbol_conf.demangle_kernel,
> > "Enable kernel symbol demangling"),
> > OPT_BOOLEAN(0, "mem-mode", &report.mem_mode, "mem access profile"),
> > --
> > 2.34.1
> >