Re: [PATCH v2 2/2] mtd: spi-nor: winbond: Add support for w25q02jv

[Miquel Raynal]

Hi Christophe,

On 09/01/2025 at 21:23:13 +01, Christophe JAILLET <christophe.jaillet@xxxxxxxxxx> wrote:

> Le 09/01/2025 à 21:17, Miquel Raynal a écrit :
>> Add support for Winbond w25q02jv spi-nor chip which shares most of
>> w25q01jv's specificities as, this time, the chip is made of 4 different
>> dies.
>> Link:
>> https://www.winbond.com/resource-files/W25Q02JV_DTR%20RevD%2007092024%20Plus.pdf
>> Signed-off-by: Miquel Raynal <miquel.raynal@xxxxxxxxxxx>
>> ---
>
> ...
>
>> diff --git a/drivers/mtd/spi-nor/winbond.c b/drivers/mtd/spi-nor/winbond.c
>> index a4c0d99dde4fcd2b123eb7ded4f7822110c6a4ae..d82962e0bf7d8e00b305fd838274a58c34dd6c4e 100644
>> --- a/drivers/mtd/spi-nor/winbond.c
>> +++ b/drivers/mtd/spi-nor/winbond.c
>> @@ -305,6 +305,10 @@ static const struct flash_info winbond_nor_parts[] = {
>>   	}, {
>>   		.id = SNOR_ID(0xef, 0x70, 0x19),
>>   		.name = "w25q256jvm",
>> +	}, {
>> +		.id = SNOR_ID(0xef, 0x70, 0x22),
>> +		/* W25Q02JV */
>
> Nitpick: The place of the comment is not consistent with patch 1/2.

That's right, I'll correct.

Thanks,
Miquèl