Re: [PATCH v2] staging: gpib: Modernize gpib_interface_t initialization and make static

[Greg KH]

On Wed, Jan 08, 2025 at 06:41:21PM +0100, Dave Penkler wrote:
> All interface drivers were using the old style initialization of
> this struct
> 
> field : value;
> 
> This generated the followng sparse warning, for example:
> agilent_82357a/agilent_82357a.c:1492:1: warning: obsolete struct initializer, use C99 syntax
> 
> Change the initialization to use the C99 syntax
> 
> .field = value;
> 
> This also resolves the checkpatch constraint of no indentation.
> 
> These structs were also not declared as static, unnecessarily polluting
> the symbol namespace and generating the following sparse warnings,
> for example:
> 
> agilent_82357a/agilent_82357a.c:1465:18: warning: symbol 'agilent_82357a_gpib_interface' was not declared. Should it be static?
> 
> Declare them as static and remove any conflicting extern declarations
> in the corresponding include files.
> 
> Signed-off-by: Dave Penkler <dpenkler@xxxxxxxxx>
> ---
> v1 -> v2 Add subsystem prefix to subject

Please test-build your changes before sending them out :(

thanks,

greg k-h