Re: [PATCH v5 03/14] iommufd/fault: Move iommufd_fault_iopf_handler() to header

From: Jason Gunthorpe
Date: Fri Jan 10 2025 - 12:25:41 EST


On Tue, Jan 07, 2025 at 09:10:06AM -0800, Nicolin Chen wrote:
> The new vEVENTQ object will need a similar function for drivers to report
> the vIOMMU related events. Split the common part out to a smaller helper,
> and place it in the header so that CONFIG_IOMMUFD_DRIVER_CORE can include
> that in the driver.c file for drivers to use.
>
> Then keep iommufd_fault_iopf_handler() in the header too, since it's quite
> simple after all.
>
> Reviewed-by: Kevin Tian <kevin.tian@xxxxxxxxx>
> Reviewed-by: Lu Baolu <baolu.lu@xxxxxxxxxxxxxxx>
> Signed-off-by: Nicolin Chen <nicolinc@xxxxxxxxxx>
> ---
> drivers/iommu/iommufd/iommufd_private.h | 20 +++++++++++++++++++-
> drivers/iommu/iommufd/fault.c | 17 -----------------
> 2 files changed, 19 insertions(+), 18 deletions(-)

Reviewed-by: Jason Gunthorpe <jgg@xxxxxxxxxx>

Jason