Re: [PATCH v4 01/14] of: Correct child specifier used as input of the 2nd nexus node
From: Rob Herring (Arm)
Date: Fri Jan 10 2025 - 12:38:49 EST
On Thu, 09 Jan 2025 21:26:52 +0800, Zijun Hu wrote:
> From: Zijun Hu <quic_zijuhu@xxxxxxxxxxx>
>
> API of_parse_phandle_with_args_map() will use wrong input for nexus node
> Nexus_2 as shown below:
>
> Node_1 Nexus_1 Nexus_2
> &Nexus_1,arg_1 -> arg_1,&Nexus_2,arg_2' -> &Nexus_2,arg_2 -> arg_2,...
> map-pass-thru=<...>
>
> Nexus_1's output arg_2 should be used as input of Nexus_2, but the API
> wrongly uses arg_2' instead which != arg_2 due to Nexus_1's map-pass-thru.
>
> Fix by always making @match_array point to @initial_match_array into
> which to store nexus output.
>
> Fixes: bd6f2fd5a1d5 ("of: Support parsing phandle argument lists through a nexus node")
> Cc: stable@xxxxxxxxxxxxxxx
> Signed-off-by: Zijun Hu <quic_zijuhu@xxxxxxxxxxx>
> ---
> drivers/of/base.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Applied, thanks!