Re: [PATCH] kbuild: Strip runtime const RELA sections correctly
From: Linus Torvalds
Date: Fri Jan 10 2025 - 13:33:37 EST
On Fri, 10 Jan 2025 at 10:11, Ard Biesheuvel <ardb@xxxxxxxxxx> wrote:
>
> I suppose this is a consequence of 8962b6b475bddc ("kbuild: print
> short log in addition to the whole command with V=1") which introduced
> an $(if ) where the else branch is simply ':' and so it always
> succeeds.
Hmm. Odd. I don't see why that part of the commit exists, and you're
right, that seems like a bad idea.
And removing that odd $(if..) and making it just do
cmd = @set -e; $($(quiet)log_print) $(delete-on-interrupt) $(cmd_$(1))
doesn't seem to have any obvious negative effects.
I'm probably missing some obvious reason why that $(if..) was added,
it's been that way for two years now.
Linus