Re: [PATCH v5 5/6] cxl/events: Update Memory Module Event Record to CXL spec rev 3.1

[Ira Weiny]

shiju.jose@ wrote:
> From: Shiju Jose <shiju.jose@xxxxxxxxxx>
> 

[snip]

> @@ -724,6 +752,7 @@ TRACE_EVENT(cxl_memory_module,
>  
>  		/* Memory Module Event */
>  		__field(u8, event_type)
> +		__field(u8, event_sub_type)
>  
>  		/* Device Health Info */
>  		__field(u8, health_status)
> @@ -734,6 +763,8 @@ TRACE_EVENT(cxl_memory_module,
>  		__field(u32, cor_per_err_cnt)
>  		__field(s16, device_temp)
>  		__field(u8, add_status)
> +		__field(u16, validity_flags)
> +		__array(u8, comp_id, CXL_EVENT_GEN_MED_COMP_ID_SIZE)
>  	),


With the change of the packing of the record.

Reviewed-by: Ira Weiny <ira.weiny@xxxxxxxxx>


diff --git a/drivers/cxl/core/trace.h b/drivers/cxl/core/trace.h
index cfb8de6f9739..5989e5f9f38d 100644
--- a/drivers/cxl/core/trace.h
+++ b/drivers/cxl/core/trace.h
@@ -753,7 +753,6 @@ TRACE_EVENT(cxl_memory_module,
 
                /* Memory Module Event */
                __field(u8, event_type)
-               __field(u8, event_sub_type)
 
                /* Device Health Info */
                __field(u8, health_status)
@@ -764,8 +763,9 @@ TRACE_EVENT(cxl_memory_module,
                __field(u32, cor_per_err_cnt)
                __field(s16, device_temp)
                __field(u8, add_status)
-               __field(u16, validity_flags)
+               __field(u8, event_sub_type)
                __array(u8, comp_id, CXL_EVENT_GEN_MED_COMP_ID_SIZE)
+               __field(u16, validity_flags)
        ),
 
        TP_fast_assign(