Re: [PATCH v2 2/2] hexdump: Allow skipping identical lines

[David Laight]

On Fri, 10 Jan 2025 19:42:05 +0100
Miquel Raynal <miquel.raynal@xxxxxxxxxxx> wrote:

> When dumping long buffers (especially for debug purposes) it may be very
> convenient to sometimes avoid spitting all the lines of the buffer if
> the lines are identical. Typically on embedded devices, the console
> would be wired to a UART running at 115200 bauds, which makes the dumps
> very (very) slow. In this case, having a flag to avoid printing
> duplicated lines is handy.
... 
>  enum {
>  	DUMP_FLAG_ASCII,
> +	DUMP_FLAG_SKIP_IDENTICAL_LINES,
>  };
...
> +		if (flags & DUMP_FLAG_SKIP_IDENTICAL_LINES) {


That doesn't look right to me.
You want:
enum {
	DUMP_FLAG_HEX_ONLY = false,
	DUMP_FLAG_ASCII = true,
	DUMP_FLAG_SKIP_IDENTICAL_LINES = BIT(1),
};

and maybe you can get away with not changing all the other files.

	David